refactor: abstract out Launcher > ILauncher/SqexLauncher #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es ActozLauncher/ShandaLauncher for future use
|
Would it be more reasonable to abstract out the Steam Launcher into its own class? Especially considering there are three different platforms for the international version of FFXIV and a bool is a bit awkward to deal with that… (Something like a |
|
@marzent Yeah, I think that makes sense for dealing with the weirdness of Steam, good call! I'll do that. |
|
Hi, I think this pull will be a great help for what we're doing in XIVLauncherCN, and we'll be grateful if it can be merged to our upstream soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and adds barebones ActozLauncher / ShandaLauncher for future use (or not).
This refactor helps to prepare XL for the possibility of supporting logins and patching for KR/CN FFXIV, although there would be a lot more work/complexity there (especially around Dalamud and the different game versions). In reality, it's mainly to be able to track KR/CN game versions in Thaliak, though of course I'd love to try to clean things up and upstream these changes.