Try to avoid tempfile collisions in more places #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues such as #1409 were reported by several users, and cleaning up their temp files seemed to solve the problem. We already have
PlatformHelpers.GetTempFileName()(which is used inDalamudUpdater.cs) as a method for getting a more "collision resistant" temp file path, so I replaced other calls toPath.GetTempFileName()with that.I also added an
xivlauncher_prefix to our temp file names as I figure it's polite to let users know who is creating their temp files, and it could be useful for detecting bugs in the future (in case we are somehow responsible for this excessive temp file pollution, for example). If you'd prefer not to change this part, let me know and I'll remove it.This is my first PR to FFXIVQuickLauncher so let me know if there's anything else I should do.