Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(deploy): validate on CreateDeployment #1236

Merged
merged 2 commits into from
Jan 8, 2025

Merge branch 'main' into enhance/validate-deploy-on-create

99942e4
Select commit
Loading
Failed to load commit list.
Merged

enhance(deploy): validate on CreateDeployment #1236

Merge branch 'main' into enhance/validate-deploy-on-create
99942e4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 8, 2025 in 0s

56.57% (target 90.00%)

View this Pull Request on Codecov

56.57% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 56.57%. Comparing base (f34ffb9) to head (99942e4).

Files with missing lines Patch % Lines
api/deployment/create.go 0.00% 20 Missing ⚠️
api/deployment/get_config.go 0.00% 16 Missing ⚠️
compiler/types/pipeline/deployment.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   56.60%   56.57%   -0.03%     
==========================================
  Files         628      628              
  Lines       35578    35596      +18     
==========================================
  Hits        20139    20139              
- Misses      14759    14777      +18     
  Partials      680      680              
Files with missing lines Coverage Δ
compiler/types/pipeline/deployment.go 89.28% <0.00%> (ø)
api/deployment/get_config.go 0.00% <0.00%> (ø)
api/deployment/create.go 0.00% <0.00%> (ø)