-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: status endpoints #1235
feat: status endpoints #1235
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
- Coverage 56.66% 56.60% -0.06%
==========================================
Files 626 628 +2
Lines 35541 35578 +37
==========================================
Hits 20139 20139
- Misses 14722 14759 +37
Partials 680 680
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test fail. swagger annotation is defining GetStatus
twice. otherwise 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about dropping email
from the build status endpoint at least? maybe deploy_payload
, as well.
implements go-vela/community#749 in a way that doesnt impact current status svg responses.
instead, two new endpoints to get unauthenticated access to "lite" versions of repo and builds.
Concerns
/badge
endpoint for "private repos" have never been protected, but this is obviously opening the door much wider.