-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deployment config for expected params and targets #1214
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
- Coverage 56.91% 56.88% -0.04%
==========================================
Files 599 602 +3
Lines 32904 33098 +194
==========================================
+ Hits 18727 18827 +100
- Misses 13541 13627 +86
- Partials 636 644 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Additional context: go-vela/community#1002
This change will allow for the
deployment
block in Vela pipeline files:These configurations can also be templated using the standard template format already existing today in Vela:
Deployment configurations can also be requested using the new API endpoint:
GET /api/v1/deployments/:org/:repo/config
This will allow for the CLI and UI to validate deployments prior to their launch. However, because you can create deployments in other ways outside the scope of Vela, and Vela still will process the resulting webhook, this PR also validates the incoming deployment against the config and will stop the compilation if there's a mismatch.