Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented ability to dynamically reload TLS certificates #866

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
271 changes: 271 additions & 0 deletions cert_watcher_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,271 @@
// Copyright (c) 2015-2024 Jeevanandam M ([email protected]), All rights reserved.
// resty source code and usage is governed by a MIT style
// license that can be found in the LICENSE file.

package resty

import (
"crypto/rand"
"crypto/rsa"
"crypto/tls"
"crypto/x509"
"crypto/x509/pkix"
"encoding/pem"
"fmt"
"math/big"
"net"
"net/http"
"os"
"path/filepath"
"testing"
"time"
)

type certPaths struct {
RootCAKey string
RootCACert string
TLSKey string
TLSCert string
}

func TestClient_SetRootCertificateWatcher(t *testing.T) {
// For this test, we want to:
// - Generate root CA
// - Generate TLS cert signed with root CA
// - Start an HTTPS server
// - Create a resty client with SetRootCertificateWatcher
// - Send multiple request and re-generate the certs periodically to reproduce renewal

certDir := t.TempDir()
paths := certPaths{
RootCAKey: filepath.Join(certDir, "root-ca.key"),
RootCACert: filepath.Join(certDir, "root-ca.crt"),
TLSKey: filepath.Join(certDir, "tls.key"),
TLSCert: filepath.Join(certDir, "tls.crt"),
}

port := findAvailablePort(t)
generateCerts(t, paths)
startHTTPSServer(fmt.Sprintf(":%d", port), paths)

//client := New().SetRootCertificate(paths.RootCACert).SetDebug(true)
client := New().SetRootCertificateWatcher(paths.RootCACert, &CertWatcherOptions{
PoolInterval: time.Second * 1,
}).SetDebug(true)

tr, err := client.Transport()
if err != nil {
t.Fatal(err)
}
// Make sure that TLS handshake happens for all request
// (otherwise, test may succeed because 1st TLS session is re-used)
tr.DisableKeepAlives = true

url := fmt.Sprintf("https://localhost:%d/", port)

for i := 0; i < 5; i++ {
t.Logf("i = %d", i)
res, err := client.R().Get(url)
if err != nil {
t.Fatal(err)
}

assertEqual(t, res.StatusCode(), http.StatusOK)

if i%2 == 1 {
// Re-generate certs to simulate renewal scenario
generateCerts(t, paths)
}
time.Sleep(time.Second * 1)
}

err = client.Close()
assertNil(t, err)
}

func startHTTPSServer(addr string, path certPaths) {
tlsConfig := &tls.Config{
GetCertificate: func(*tls.ClientHelloInfo) (*tls.Certificate, error) {
cert, err := tls.LoadX509KeyPair(path.TLSCert, path.TLSKey)
if err != nil {
return nil, err
}
return &cert, nil
},
}

http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusOK)
})

srv := &http.Server{
Addr: addr,
TLSConfig: tlsConfig,
}

go func() {
err := srv.ListenAndServeTLS("", "")
if err != nil {
panic(err)
}
}()
}

func findAvailablePort(t *testing.T) int {
port := -1

for port == -1 {
listener, err := net.Listen("tcp", ":0")
if err != nil {
continue
}
port = listener.Addr().(*net.TCPAddr).Port
if err := listener.Close(); err != nil {
t.Fatal(err)
}
}

return port
}

func generateCerts(t *testing.T, paths certPaths) {
rootKey, rootCert, err := generateRootCA(paths.RootCAKey, paths.RootCACert)
if err != nil {
t.Fatal(err)
}

if err := generateTLSCert(paths.TLSKey, paths.TLSCert, rootKey, rootCert); err != nil {
t.Fatal(err)
}
}

// Generate a Root Certificate Authority (CA)
func generateRootCA(keyPath, certPath string) (*rsa.PrivateKey, []byte, error) {
// Generate the key for the Root CA
rootKey, err := generateKey()
if err != nil {
return nil, nil, err
}

// Define the maximum value you want for the random big integer
max := new(big.Int).Lsh(big.NewInt(1), 256) // Example: 256 bits

// Generate a random big.Int
randomBigInt, err := rand.Int(rand.Reader, max)
if err != nil {
return nil, nil, err
}

// Create the root certificate template
rootCertTemplate := &x509.Certificate{
SerialNumber: randomBigInt,
Subject: pkix.Name{
Organization: []string{"YourOrg"},
Country: []string{"US"},
Province: []string{"State"},
Locality: []string{"City"},
CommonName: "YourRootCA",
},
NotBefore: time.Now(),
NotAfter: time.Now().Add(time.Hour * 10),
KeyUsage: x509.KeyUsageCertSign | x509.KeyUsageCRLSign,
IsCA: true,
BasicConstraintsValid: true,
}

// Self-sign the root certificate
rootCert, err := x509.CreateCertificate(rand.Reader, rootCertTemplate, rootCertTemplate, &rootKey.PublicKey, rootKey)
if err != nil {
return nil, nil, err
}

// Save the Root CA key and certificate
if err := savePEMKey(keyPath, rootKey); err != nil {
return nil, nil, err
}
if err := savePEMCert(certPath, rootCert); err != nil {
return nil, nil, err
}

return rootKey, rootCert, nil
}

// Generate a TLS Certificate signed by the Root CA
func generateTLSCert(keyPath, certPath string, rootKey *rsa.PrivateKey, rootCert []byte) error {
// Generate a key for the server
serverKey, err := generateKey()
if err != nil {
return err
}

// Parse the Root CA certificate
parsedRootCert, err := x509.ParseCertificate(rootCert)
if err != nil {
return err
}

// Create the server certificate template
serverCertTemplate := &x509.Certificate{
SerialNumber: big.NewInt(2),
Subject: pkix.Name{
Organization: []string{"YourOrg"},
CommonName: "localhost",
},
NotBefore: time.Now(),
NotAfter: time.Now().Add(time.Hour * 10),
KeyUsage: x509.KeyUsageDigitalSignature | x509.KeyUsageKeyEncipherment,
ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},
IPAddresses: []net.IP{net.ParseIP("127.0.0.1")},
DNSNames: []string{"localhost"},
}

// Sign the server certificate with the Root CA
serverCert, err := x509.CreateCertificate(rand.Reader, serverCertTemplate, parsedRootCert, &serverKey.PublicKey, rootKey)
if err != nil {
return err
}

// Save the server key and certificate
if err := savePEMKey(keyPath, serverKey); err != nil {
return err
}
if err := savePEMCert(certPath, serverCert); err != nil {
return err
}

return nil
}

func generateKey() (*rsa.PrivateKey, error) {
return rsa.GenerateKey(rand.Reader, 2048)
}

func savePEMKey(fileName string, key *rsa.PrivateKey) error {
keyFile, err := os.Create(fileName)
if err != nil {
return err
}
defer keyFile.Close()

privateKeyPEM := &pem.Block{
Type: "RSA PRIVATE KEY",
Bytes: x509.MarshalPKCS1PrivateKey(key),
}

return pem.Encode(keyFile, privateKeyPEM)
}

func savePEMCert(fileName string, cert []byte) error {
certFile, err := os.Create(fileName)
if err != nil {
return err
}
defer certFile.Close()

certPEM := &pem.Block{
Type: "CERTIFICATE",
Bytes: cert,
}

return pem.Encode(certFile, certPEM)
}
Loading