Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/debug issues #282

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Fix/debug issues #282

merged 2 commits into from
Dec 17, 2023

Conversation

fredbi
Copy link
Member

@fredbi fredbi commented Dec 13, 2023

refactored debug logging

Signed-off-by: Frederic BIDON [email protected]

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (442694d) 82.27% compared to head (9a714db) 82.01%.

❗ Current head 9a714db differs from pull request most recent head b084b1b. Consider uploading reports for the commit b084b1b to get more accurate results

Files Patch % Lines
middleware/context.go 54.83% 13 Missing and 1 partial ⚠️
middleware/router.go 75.60% 10 Missing ⚠️
middleware/request.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   82.27%   82.01%   -0.27%     
==========================================
  Files          45       45              
  Lines        3447     3491      +44     
==========================================
+ Hits         2836     2863      +27     
- Misses        499      516      +17     
  Partials      112      112              
Flag Coverage Δ
oldstable 82.01% <69.41%> (-0.27%) ⬇️
stable 82.01% <69.41%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi fredbi marked this pull request as draft December 13, 2023 20:39
@fredbi
Copy link
Member Author

fredbi commented Dec 13, 2023

TODO: need unit tests -> Done

* relinted debugLog as debugLogf
* fixes go-openapi#244 (use logger.Debugf rather than logger.Printf)
* fixes go-openapi#118 (added support for injectable logger in Context and DefaultRouter)
* removed global debug logger

Signed-off-by: Frederic BIDON <[email protected]>
@fredbi fredbi marked this pull request as ready for review December 14, 2023 17:56
@fredbi fredbi merged commit d4904c3 into go-openapi:master Dec 17, 2023
8 checks passed
@fredbi fredbi deleted the fix/debug-issues branch December 26, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debugLog func must use Logger.Debugf Unify the logging format when debugging is enabled
2 participants