quota: realtime usage update for metrics, logical/physical sizes, and data points #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data points Without this patch, it is possible for some namespaces to have a window of 1-3 `carbonserver.quota-usage-report-frequency` to conduct quota enforcement penetration. There are two cases that need to be addressed, dir nodes that are already annotated with proper quota config, nodes that don't have quota config due to realtime insert via *CarbonserverListener.newMetricsChan. For annotated nodes, trie index resovle it via realtime metric counter update in *trieIndex.insert. For unannotated nodes, a new config are introduced, which is called transient-child-limit. With this config, during realtime insert, trieIndex would annotate the new dir nodes of parent nodes that enables that config. This is not the most proper way to address the issue, but a trade off of correctness, reliability, complexity, and performance. Re-iterating all quota configs for every realtime insert is nice but expensive. However, as always, I could be wrong. But this seems to be working in my tests.
bom-d-van
force-pushed
the
quota/realtime-usage
branch
from
c9012dd
to
2073cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, it is possible for some namespaces to have a window of 1-3
carbonserver.quota-usage-report-frequencyto conduct quota enforcement penetration.
There are two cases that need to be addressed, dir nodes that are already annotated with proper quota config, nodes that
don't have quota config due to realtime insert via *CarbonserverListener.newMetricsChan.
For annotated nodes, trie index resovle it via realtime metric counter update in *trieIndex.insert.
For unannotated nodes, a new config are introduced, which is called transient-child-limit. With this config, during realtime
insert, trieIndex would annotate the new dir nodes of parent nodes that enables that config. This is not the most proper way
to address the issue, but a trade off of correctness, reliability, complexity, and performance. Re-iterating all quota configs
for every realtime insert is nice but expensive. However, as always, I could be wrong. But this seems to be working in my tests.