Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr: clean from direct use zipper/limiter from carbonapi app global config #811

Closed
wants to merge 1 commit into from

Conversation

msaf1980
Copy link
Collaborator

@msaf1980 msaf1980 commented Dec 18, 2023

Try to refactor expr package for avoid direct usage zipper/limiter from carbonapi app global config.
Not a complete refactor, no separate Eval/Fetch (may be in future).

@msaf1980 msaf1980 marked this pull request as draft December 18, 2023 16:15
expr/expr.go Outdated Show resolved Hide resolved
@msaf1980 msaf1980 force-pushed the feat/expr branch 2 times, most recently from bd29447 to e325db3 Compare December 18, 2023 20:32
@msaf1980 msaf1980 changed the title expr: clean from direct use config zipper/limiter expr: clean from direct use zipper/limiter from carbonapi app global config. Dec 19, 2023
@msaf1980 msaf1980 changed the title expr: clean from direct use zipper/limiter from carbonapi app global config. expr: clean from direct use zipper/limiter from carbonapi app global config Dec 19, 2023
@msaf1980 msaf1980 force-pushed the feat/expr branch 2 times, most recently from 76354ad to 081ee1e Compare February 22, 2024 10:03
@msaf1980
Copy link
Collaborator Author

Reason for do this - use expr methods in separate product. Use for configure it with carbonapi app config is bad design.

@msaf1980
Copy link
Collaborator Author

@npazosmendez Another variant of expr refactor. It's compromise (global evaluator exist, but only in expr). May be less clear, but more simple and no Do changes is required.

@msaf1980
Copy link
Collaborator Author

msaf1980 commented Feb 23, 2024

Not complete solution. #818 solved more problems, but required functions Do signature change

There's other cases that are even more tricky, or maybe even impossible. For example aliasQuery

@msaf1980 msaf1980 marked this pull request as draft February 23, 2024 05:20
@msaf1980 msaf1980 closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant