DropIndex and RenameIndex fail in postgres driver when TablePrefix is… #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… used to specify schema
Explain your user case and expected results
To reproduce the issue for each function, comment in the respective block in TestGORM. run tests with the dialect set to "postgres" as there is dialect-specific SQL used to create the non-default schema.
I would expect that these two functions would use m.CurrentTable to table TablePrefix into account, but they do not. Explicitly adding the schema to the index name in the function argument makes these tests work, which confirms the cause.