Refactor request context #32956
Merged
Refactor request context #32956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
modifies/api
wxiaoguang
force-pushed
the
refactor-ctx
branch
from
ef76b92 to
0d6322a
Compare
wxiaoguang
force-pushed
the
refactor-ctx
branch
from
0d6322a to
98a0b71
Compare
wxiaoguang
force-pushed
the
refactor-ctx
branch
2 times, most recently
from
86888fe to
87c5bb8
Compare
wxiaoguang
force-pushed
the
refactor-ctx
branch
2 times, most recently
from
879a8e7 to
633f0e7
Compare
wxiaoguang
force-pushed
the
refactor-ctx
branch
from
633f0e7 to
9bec2cc
Compare
lunny
approved these changes
Dec 22, 2024
GiteaBot
added
lgtm/need 1
lunny
added
the
type/refactoring
Zettat123
approved these changes
Dec 24, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce RequestContext: is a short-lived context that is used to store request-specific data.
RequestContext could be used to clean form tmp files, close context git repo, and do some tracing in the future.
Then a lot of legacy code could be removed or improved. For example: most
ctx.Repo.GitRepo.Close()could be removed because the git repo could be closed when the request is done.