Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add profile wiki to org home #32947

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: Add profile wiki to org home #32947

wants to merge 3 commits into from

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 22, 2024 •
edited
Loading

Close #7077

Add wiki to "/{org}/.profile" repo, then it shows the tab:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 22, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 22, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Dec 22, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 22, 2024
Open
@wxiaoguang
Copy link
Contributor Author

⚠️ DOCUMENT ⚠️

Please remember to update the documents

@wxiaoguang wxiaoguang marked this pull request as draft December 22, 2024 14:15
@wxiaoguang wxiaoguang changed the title Add profile wiki to org home WIP: Add profile wiki to org home Dec 24, 2024
@wxiaoguang
Merge branch 'main' into add-org-wiki
4e7465a 
# Conflicts:
#	routers/web/org/home.go
@wxiaoguang wxiaoguang changed the title WIP: Add profile wiki to org home Add profile wiki to org home Dec 31, 2024
@wxiaoguang wxiaoguang marked this pull request as ready for review December 31, 2024 04:44
@wxiaoguang wxiaoguang mentioned this pull request Dec 31, 2024
Merged
3 tasks
@lunny lunny added the docs-update-needed The document needs to be updated synchronously label Dec 31, 2024
@wxiaoguang wxiaoguang added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 31, 2024
@lunny lunny added this to the 1.24.0 milestone Dec 31, 2024
@wxiaoguang wxiaoguang marked this pull request as draft December 31, 2024 04:52
@wxiaoguang
Copy link
Contributor Author

See some edge cases ... the "view as" affects the "wiki link", it can't be in the menu tab.

Will try to figure out whether there could be better UI/UX solutions.

@github-actions github-actions bot removed the docs-update-needed The document needs to be updated synchronously label Dec 31, 2024
@wxiaoguang wxiaoguang changed the title Add profile wiki to org home WIP: Add profile wiki to org home Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Add wiki page at organization level
3 participants
@wxiaoguang @lunny @GiteaBot