Fix maven pom inheritance #32943
Merged
Fix maven pom inheritance #32943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
force-pushed
the
fix-pom-parent
branch
from
fa35cd8 to
768e7e5
Compare
wxiaoguang
force-pushed
the
fix-pom-parent
branch
from
768e7e5 to
1cd5fa1
Compare
github-actions
bot
added
the
modifies/api
lunny
approved these changes
Dec 22, 2024
GiteaBot
added
lgtm/need 1
|
Just a quick remark from my side: This appears very similar to the fix from Forgejo. Since versions are determined via the path parameter and not from the XML property, there doesn't seem to be a need to inherit the version from the parent. How would you handle parsing something like this: |
Not supported yet? |
|
It's totally okay to rely on the version provided by Maven as a path parameter, as it can contain parameters and be overridden by Maven using command-line options, such as |
Zettat123
approved these changes
Dec 25, 2024
GiteaBot
added
lgtm/done
wxiaoguang
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Dec 25, 2024
wxiaoguang
added a commit
that referenced
this pull request
Dec 25, 2024
Backport #32943 by wxiaoguang Fix #30568 At the moment, here only `GroupID` (no `Version`) is parsed & used Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 25, 2024
* giteaofficial/main: demilestone should not include milestone (go-gitea#32923) fix textarea newline handle (go-gitea#32966) Fix Azure blob object `Seek` (go-gitea#32974) Fix maven pom inheritance (go-gitea#32943) Refactor arch route handlers (go-gitea#32972) [skip ci] Updated translations via Crowdin Refactor tmpl and blob_excerpt (go-gitea#32967) Clarify path param naming (go-gitea#32969) Refactor getpatch/getdiff functions and remove unnecessary fallback (go-gitea#32817) Refactor request context (go-gitea#32956)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30568
At the moment, here only
GroupID(noVersion) is parsed & used