-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save gitea specific settings for vscode #32279
base: main
Are you sure you want to change the base?
Conversation
e.g. allow to run tests from IDE
I prefer this change, as I always need to add the TAGS manually in command line, but if I have custom settings, it will be overwritten by this change? |
.vscode/* | ||
!.vscode/settings.json | ||
!.vscode/launch.json | ||
!.vscode/extensions.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.vscode/* | |
!.vscode/settings.json | |
!.vscode/launch.json | |
!.vscode/extensions.json | |
.vscode |
The gitignore could be kept as-is. It doesn't affected the manually added files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but this is the more compliant way!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think it is more compliant. Instead it just makes thing more complicated.
By using a single .vscode
, everything just works well, and the manually added files are always correctly handled.
this file has been add in here now. gitea/contrib/ide/vscode/settings.json Lines 1 to 4 in 0196b35
|
Ah, we already have it. So this PR is unnecessary? |
for beginner it's easy to just clone and start ... not sure why we should complicate onboarding ... |
It would cause a lot of conflicts for developers who want to modify |
I have said here. #32279 (comment) |
e.g. allow to run tests from IDE
Sponsored by Kithara Software GmbH