Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save gitea specific settings for vscode #32279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 16, 2024

e.g. allow to run tests from IDE


Sponsored by Kithara Software GmbH

e.g. allow to run tests from IDE
@6543 6543 added the type/docs This PR mainly updates/creates documentation label Oct 16, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 16, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2024
@yp05327
Copy link
Contributor

yp05327 commented Oct 17, 2024

I prefer this change, as I always need to add the TAGS manually in command line, but if I have custom settings, it will be overwritten by this change?
VSCode will save workspace level settings in settings.json, if I have some custom changes, e.g. the font size, how to cover this case, as it is allowed before.

Comment on lines +17 to +20
.vscode/*
!.vscode/settings.json
!.vscode/launch.json
!.vscode/extensions.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.vscode/*
!.vscode/settings.json
!.vscode/launch.json
!.vscode/extensions.json
.vscode

The gitignore could be kept as-is. It doesn't affected the manually added files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but this is the more compliant way!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it is more compliant. Instead it just makes thing more complicated.

By using a single .vscode, everything just works well, and the manually added files are always correctly handled.

@a1012112796
Copy link
Member

this file has been add in here now.

{
"go.buildTags": "'sqlite sqlite_unlock_notify'",
"go.testFlags": ["-v"]
}

@yp05327
Copy link
Contributor

yp05327 commented Oct 17, 2024

Ah, we already have it. So this PR is unnecessary?

@6543
Copy link
Member Author

6543 commented Oct 17, 2024

for beginner it's easy to just clone and start ... not sure why we should complicate onboarding ...

@wxiaoguang
Copy link
Contributor

for beginner it's easy to just clone and start ... not sure why we should complicate onboarding ...

It would cause a lot of conflicts for developers who want to modify .vscode/settings.json, unless you could be 100% sure that nobody would edit the settings.json for their personal usage.

@yp05327
Copy link
Contributor

yp05327 commented Oct 17, 2024

I have said here. #32279 (comment)
You can not change the workspace level settings any more. As VSCode will automatically edit this file. I think this should be blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants