cancel running jobs if possible when run Scheduler.StopJobs() #819
+71
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
when run Scheduler.StopJobs(), the scheduler will wait for the running jobs to be completed. If there are long running jobs, it will always return "timed out waiting for jobs to finish".
This pr try to cancel the running jobs if possible
Which issue(s) does this PR fix/relate to?
Resolves #818
List any changes that modify/break current functionality
You can now add a task function which accept ctx as the first param, but you do need pass a ctx actually, gocron will handle it properly
but if you have you own ctx, fell free to pass it
or you can also pass it as a job option to control the whole thing
Have you included tests for your changes?
yes
Did you document any new/modified functionality?
example_test.go
README.md
Notes