ClientIP middleware proposal, intended to replace RealIP #967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed solution for the RealIP middleware issues outlined at:
#708
https://adam-p.ca/blog/2022/03/x-forwarded-for/
#711
#453
#908
Summary of differences:
RealIP
,ClientIP
middleware doesn't change the value ofreq.RemoteAddr
.GetClientIP()
getterbelonging to their infrastructure, such as proxies or Load Balances, depending on their setup
Kudos to Adam Pritchard, Jonathan Yu, Yuya Okumura, Liam Stanley, and everyone else involved in the detailed reports and discussion.
I'm seeking early feedback and reviews on the proposed API.
CC @jawnsy @adam-p @convto @Dirbaio @pkieltyka @mfridman @lrstanley @n33pm
P.S.: This PR uses the
"net/netip"
package and assumes that we'll accept proposal to drop support for Go 1.17 and older. Please have a look!Example usage:
Get the client IP address value in HTTP handler: