-
-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed the NewCompressor logic to be support wildcards in the defaul… #921
base: master
Are you sure you want to change the base?
Conversation
eteran
commented
Jun 12, 2024
•
edited
Loading
edited
- changed the NewCompressor logic to be support wildcards in the default set like it already did for a custom list by reusing that logic
- made defaultCompressibleContentTypes contain "text/*" as all text mime types are arguably very compressible added
- application/xml to defaultCompressibleContentTypes since it is also a common XML mime type
…t set like it already did for a custom list by reusing that logic made defaultCompressibleContentTypes contain "text/*" as all text mime types are arguably very compressible added application/xml to defaultCompressibleContentTypes since it is also a common XML mime type
@Neurostep can you help review this please? |
Looks like it fails here:
So perhaps I just need to update the tests now that some other things are being compressed. I'll see if I can fix it real quick |
7 regular rules and 1 wildcard in the default ruleset
I updated the tests and now things pass locally. However, it looks like perhaps the CI workflow didn't rerun on github? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes look good to me 👍 I wonder if we should bump the minor version here since we are going to change the default behavior of the middleware and all of a sudden for some clients the middleware is going to compress all text/*
content types 🤔
Just wanted to follow up to see if there was anything you need on my end to help move things to the next steps. |