Remove GSFakeNSMenuItem class #7
Open
+15
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class doesn't appear to do anything but serve as a pass-through for the original object, so why not just use that?
williameveretteggplant
changed the title
qmfrederik
reviewed
Oct 26, 2024
| @@ -151,7 +71,7 @@ void initialize_lock() | |||
| } | |||
|
|
|||
| // find all subitems for the given items... | |||
| HMENU r_build_menu_for_itemmap(NSMenu *menu, BOOL asPopUp, BOOL fakeItem, NSMapTable *itemMap) | |||
There was a problem hiding this comment.
I think it's a great idea to rename the variable fakeItem to notPullDown (or something similar) as this value is initially set to ![cell pullsDown]in displayPopUpMenu (line 554). But I'd suggest we update the name throughout, i.e. rename the fake variable in displayPopUpMenu and any other method that may use that name?
|
Left a comment, LGTM otherwise. @rfm @fredkiefer @gcasa - any thoughts? |
|
I am not familiar with this theme. If popup menus still work with your change, this sounds like a simplification that we should use. But @gcasa should decide. |
|
I agree with @fredkiefer. Please test pop up menus. If that works then the change is acceptable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class doesn't appear to do anything but serve as a pass-through for the original object, so why not just use that?