Enable or disable NSMenuItems correctly #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Forcing the @rfm @fredkiefer @gcasa - any thoughts? If not, I'll merge this early next week. |
|
I have no problem as long as the proposed solution works better. Also, as the saying goes, there is nothing so permanent as a "temporary fix." :) |
|
This just reverts the change Gregory made four years ago. Does anybody remember what the issue at that time was? Is there anything on the mailing lists? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the flags for NSMenuItems based on whether or not the items are enabled.