Don't use std::visit for formatting. It is too slow and complex #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsallay
force-pushed
the
faster-format
branch
from
fe09419
to
0078296
Compare
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
Signed-off-by: John Sallay <[email protected]>
mormj
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By manually going through the possibilities, the code is easier to read and understand and the total compilation time goes down by around 15%.