make sure to not loose waypoints

gnosisguild · Jan 16, 2025 · 047f139 · 047f139
1 parent d73211f
commit 047f139
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/packages/modules/src/updateAvatar.spec.ts b/packages/modules/src/updateAvatar.spec.ts
@@ -38,6 +38,28 @@ describe('updateAvatar', () => {
   })
 
   describe('Account', () => {
+    it('keeps existing waypoints', () => {
+      const currentSafe = randomAddress()
+
+      const startingPoint = createMockStartingWaypoint()
+      const roleWaypoint = createMockRoleWaypoint()
+
+      const route = createMockExecutionRoute({
+        avatar: formatPrefixedAddress(Chain.ETH, currentSafe),
+        waypoints: [startingPoint, roleWaypoint],
+      })
+
+      const safe = randomAddress()
+
+      const updatedRoute = updateAvatar(route, { safe })
+
+      expect(updatedRoute.waypoints).toEqual([
+        startingPoint,
+        roleWaypoint,
+        expect.anything(),
+      ])
+    })
+
     it('updates an existing safe endpoint', () => {
       const currentSafe = randomAddress()
 
@@ -120,7 +142,7 @@ describe('updateAvatar', () => {
 
       const updatedRoute = updateAvatar(route, { safe })
 
-      const [updatedWaypoint] = getWaypoints(updatedRoute)
+      const [, updatedWaypoint] = getWaypoints(updatedRoute)
 
       expect(updatedWaypoint.connection).toEqual({
         from: formatPrefixedAddress(Chain.GNO, moduleAddress),

diff --git a/packages/modules/src/updateAvatar.ts b/packages/modules/src/updateAvatar.ts
@@ -63,7 +63,7 @@ const updateEndWaypoint = (
 
   return {
     ...route,
-    waypoints: [startingPoint, updatedWaypoint],
+    waypoints: [startingPoint, ...waypoints, updatedWaypoint],
   }
 }