This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
Add test verifying deterministic deployment of proxy #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A refinement of my previous incantation - it was because |
bh2smith
approved these changes
Feb 2, 2021
| @@ -1,6 +1,7 @@ | |||
| import { expect } from "chai"; | |||
| import { Contract, Wallet } from "ethers"; | |||
| import { artifacts } from "hardhat"; | |||
| import Proxy from "hardhat-deploy/extendedArtifacts/EIP173Proxy.json"; | |||
fleupold
approved these changes
Feb 3, 2021
|
|
||
| EnumerableSet.AddressSet private solvers; | ||
|
|
||
| // solhint-disable-next-line no-empty-blocks | ||
| constructor(address initialOwner) CustomInitiallyOwnable(initialOwner) {} | ||
| function initializeManager(address _manager) external { |
There was a problem hiding this comment.
Why separate this from the constructor? I assume because EIP173 only works with empty constructors? Would the Ownable base contract now work again instead of implementing it ourselves?
There was a problem hiding this comment.
This because the base branch was merged right before you
Why separate this from the constructor?
Its now a "proxy upgrade function" since proxied contracts cant have constructors.
nlordell
force-pushed
the
verify-deterministic-proxy-address
branch
from
182e296 to
56e0d71
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unit test that verifies that the authenticator proxy is at a deterministically deployed.
Test Plan
It is a test!