Provide a way to avoid creating world<->pixel links in datasets #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
disable-auto-coords-link
branch
from
454ccaa to
4c4f651
Compare
|
This works for Jdaviz, thank you! |
|
So it's also working in datasets context as it should? |
dhomeier
reviewed
Jan 8, 2025
| @@ -1179,7 +1179,8 @@ def delay_callbacks(): | |||
| label = axis_label(self.coords, i) | |||
| cid = self.add_component(comp, label) | |||
| self._world_component_ids.append(cid) | |||
| self._set_up_coordinate_component_links(ndim) | |||
| if settings.AUTO_COMPUTE_COORDS_LINKS: | |||
| self._set_up_coordinate_component_links(ndim) | |||
There was a problem hiding this comment.
I assume the creation of the components above is still required.
There was a problem hiding this comment.
We could remove that but it would be a bigger change - best to try this in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires setting:
The reason this is done via settings instead of via a kwarg to
Datais because it is not always possible to pass in kwargs when e.g. loading datasets, so having a global setting makes more sense.Fixes #2525