Add CI for Python 3.13 and update dev envs #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhomeier
added
no-changelog-entry-needed
dhomeier
force-pushed
the
ci-py312
branch
3 times, most recently
from
414f93f
to
8ab890e
Compare
|
Looks like it tests some sort of third-party PNG loader, so I am not sure. What is this actually testing? That |
|
Did this test ever pass before on Windows? |
|
It did, and does for Python <=3.10. Turned out to be a locale/encoding issue hopefully solved in #2519. |
astrofrog
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing test jobs for currently 3.13rc2 and pushing the
py310-test-devenvs, which are now stuck at Astropy 6.1.3, to higher Python versions.Non-dev job for py313 is failing on missing libhdf5-dev when trying to build h5py from source; don't know how to install the apt for just a specific env.
I have down-versioned the windows-dev job here so it runs with astropy 6.1.3; upgrading to py312 produced the same data_factory failuresbut the also occur with the non-dev Windows job, so it appears to be a Python 3.11+ issue on that platform.
As far as I can tell this is incorrectly identifying the .png file as readable as an
astropy_tabular_data"Catalog".@pllim any ideas what could have happened there?
Addresses #2517