-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct y limits in ProfileViewerState when min same as max #2513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. A good choice for a default range still is somewhat arbitrary, since I cannot conceive any real data where this case would apply. But I've tested this branch with some other examples, and setting a range of at least a few percents would probably be good to have it visible in the tick marks.
I think it should be possible to extend test_limits
to cover this case?
[ci skip] Co-authored-by: Derek Homeier <[email protected]>
@dhomeier good point about very small values. I updated the code. How does it look now? |
Where is |
I had just edited the suggestion to a slightly different version to account for negative values as well, which is probably now hidden in the resolved. |
glue/glue/viewers/profile/tests/test_state.py Line 130 in 7481caf
|
@dhomeier , can u please re-suggest the neg fix so commit will credit you properly? Also feel free to push directly to this branch if that is easier. Thanks! |
Co-authored-by: Derek Homeier <[email protected]>
I don't think the Windows job failures are related? |
Suggestion is easier for now, but if you don't find time to write a test, let me know, and I can probably look into that later. |
No, the image loader failures I have seen elsewhere. |
Added a couple of tests. Please re-review. Thanks! |
Thanks! I'd parametrise that test, but cannot push to your branch. I have pushed to my own fork, so could open a PR against this, phew. |
Hmm I enabled push by maintainer, so weird it won't let you push. Did you work off my branch? If you rebase, then that might mess up the history, and not let you push without a force. |
No, I had reset to e9df453, so should be on the same history, and it is not failing on that afaict:
|
PR to my branch works too. Pls ping me there. Thx |
I created the feature branch from glue-viz/glue main, not sure if that matters. |
Parametrise yminmax-same-tests
@dhomeier , I merged your PR to my PR, so your changes is in this PR now. Thanks! |
Thanks, LGTM now! |
Thanks for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This fixes a display limit problem we see over at Cubeviz when cube is all ones.
Without this patch:
With this patch:
🐱