-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: drop runtime dependency on setuptools
#2511
Conversation
setuptools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment below. Otherwise, regarding the comment about not using item.load(), are you sure that these kind of errors should not happen anymore? If not, then in addition to removing the comment we should then actually use item.load() below in the try...except?
|
||
import setuptools | ||
logger.info("Loading external plugins using " | ||
"setuptools=={0}".format(setuptools.__version__)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep 'Loading external plugins' - just don't give the setuptools version
I don't know if there's a test to exercise this condition, but I tried replacing
so it stills seems simpler/safer to use |
eebacf7
to
c2eca70
Compare
@neutrinoceros - sounds good to me! |
@astrofrog done. Note that this is still blocked by astrofrog/mpl-scatter-density#43 |
7f3f38f
to
c609884
Compare
Actually, |
legacy: ipython==7.16.* | ||
legacy: ipykernel==5.3.* | ||
legacy: dill==0.2.* | ||
legacy: xlrd==1.2.* | ||
legacy: h5py==2.10.* | ||
legacy: mpl-scatter-density==0.7.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part is now a natural follow up to #2521
Description
This is a follow up to #2365
At the moment this breaks tests because
mpl-scatter-density
has an undeclared runtime dependency onsetuptools
(addressed at astrofrog/mpl-scatter-density#43)
I also note that the following comment
glue/glue/main.py
Lines 75 to 87 in e9df453
which was introduced in #1487, has been irrelevant since #2365 (at least in part) since it mentions behavior details that were specific to setuptools. Should this comment be removed entierely or just rephrased ?