Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pvextractor from dependencies #2497

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Carifio24
Copy link
Member

This PR removes pvextractor from the dependencies, as it's not used anywhere within the glue-core codebase. The functionality that uses pvextractor all now lives in glue-qt (where it's already a dependency).

The motivation for this is glue-viz/glue-wwt#111. The dependency on pvextractor here means that qtpy is an upstream dependency for glue-wwt, and more generally anything that depends on glue-core.

@astrofrog astrofrog merged commit 9f5554e into glue-viz:main Jul 15, 2024
20 of 27 checks passed
@neutrinoceros
Copy link
Contributor

Note that qtpy is still an indirect dependency via echo

$ uv pip tree --invert --package qtpy 
qtpy v2.4.1
└── echo v0.8.0
    ├── glue-core v1.21.1
    │   ├── glue-vispy-viewers v1.2.1
    │   │   └── glueviz v1.2.0
    │   └── glueviz v1.2.0
    └── glue-vispy-viewers v1.2.1 (*)
(*) Package tree already displayed

@Carifio24
Copy link
Member Author

@neutrinoceros Yeah, that's true. I maybe should've mentioned it in this PR description but glue-viz/echo#38 is intended to resolve that.

@astrofrog
Copy link
Member

This should now be resolved with echo v0.9.0 released (without the qtpy dependency)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants