fix: use last focused/resized view to determine shape of BqplotImageView #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's fine like this, if we also bump Line 26 in 1876875 Otherwise some people might get the old behaviour. |
|
We can use version 1.6.0 now (https://pypi.org/project/bqplot-image-gl/1.6.0/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Instead of always using the lowest cid view to determine the aspect ratio / shape of a Bqplot image viewer, use the last focused / resized one.
focused_atdescribes the time that the window of that view was last focused, whileresized_atdescribes when each viewer was last resized, so this way distortion from resizing based on a view in a popout window will be fixed once the original window is brought into focus.Needs glue-viz/bqplot-image-gl#112 to work. Let me know if you need this to use the old behaviour as a fallback with previous versions of bqplot-image-gl.
TODO:
bqplot-image-glin the dependencies once feat: resize & focus tracking in view_data bqplot-image-gl#112 is released.