Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CircularROI.center to avoid deprecation warnings with glue_core >= 1.10 #91

Merged
merged 1 commit into from
May 11, 2023
Merged

Use CircularROI.center to avoid deprecation warnings with glue_core >= 1.10 #91

merged 1 commit into from
May 11, 2023

Conversation

dhomeier
Copy link
Contributor

Description

Fixing a regression following glue-viz/glue#2391, which deprecated get_center and set_center in favour of using center and move_to consistently for all ROIs.

@dhomeier dhomeier added the bug Something isn't working label May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (336e2cc) 97.38% compared to head (aefc6b6) 97.38%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files          18       18           
  Lines        1375     1379    +4     
=======================================
+ Hits         1339     1343    +4     
  Misses         36       36
Impacted Files Coverage Δ
glue_astronomy/translators/regions.py 96.77% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dhomeier dhomeier changed the title Use CircularROI.center to avoid deprecation warnings in glue_core >= 1.10 Use CircularROI.center to avoid deprecation warnings with glue_core >= 1.10 May 11, 2023
@dhomeier dhomeier requested a review from astrofrog May 11, 2023 14:31
pllim
pllim approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW LGTM thx!

@dhomeier
Copy link
Contributor Author

Thanks for assisting with the fix!

@dhomeier dhomeier merged commit dab988a into glue-viz:main May 11, 2023
@dhomeier dhomeier deleted the unget-center branch May 11, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@astrofrog astrofrog Awaiting requested review from astrofrog

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhomeier @pllim