Support Spectrum1D objects with 2D data and 1D WCS #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to translate Spectrum1D objects with 1D spectral WCS and 2D datasets to glue objects and back, and is needed for spacetelescope/jdaviz#733. In future we should just support ND datasets with 1D WCS but the code for that will be a bit more complex and it would be easier to just wait for a release of NDCube so that we can use the compound WCS class from there. For now this PR makes it possible to support 2D spectra.
This also removes the use of SpectralCoordinate in
to_data
as glue and Spectrum1D now both support GWCS.