Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test composer scripts #18705

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

cconard96
Copy link
Contributor

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

I am not sure there is any use for the test* composer scripts anymore. The tests would probably always fail since they expect a clean GLPI installation. I left the code standards and lint scripts since they should still be OK to run outside of a container.

tests/run_tests.php should be used to run tests in a containerized environment.

@cconard96 cconard96 requested a review from cedric-anne January 10, 2025 13:20
@trasher trasher mentioned this pull request Jan 10, 2025
3 tasks
@cedric-anne cedric-anne merged commit b83954a into glpi-project:main Jan 13, 2025
8 of 9 checks passed
@SebSept
Copy link
Contributor

SebSept commented Jan 13, 2025

Thanksby the way the script to launch test as in ci is ./tests/run_tests.sh, I'll write some doc about that.

@cconard96
Copy link
Contributor Author

cconard96 commented Jan 13, 2025

Thanksby the way the script to launch test as in ci is ./tests/run_tests.sh, I'll write some doc about that.

You can also run it in interactive mode with --interactive to run tests multiple times without having to restart the containers and also specify specific tests to run.

@SebSept
Copy link
Contributor

SebSept commented Jan 13, 2025

good to know, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants