Use strict variables in Twig #18685
Draft
Use strict variables in Twig #18685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
With the default Twig configuration, accessing an unexisting variable, object property or object method will just be evaluated to
true, without triggering any error. IMHO, it is a mistake to not use thestrict_variables=trueoption and we should have done it when we started to use Twig templates.I propose to enable strict variables in GLPI 11.0, as it is a major version. Indeed, it will be considered as a breaking change by plugins developers. If we validate this change, we should add a note about this in our migration guide.
I guess we will have to fix many of our templates. For now, I just changed the option value to see how many errors our test suite will detect.