feat(forms): Move the itemtype config field for QuestionTypeItem #18681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienClairembault
approved these changes
Jan 8, 2025
cedric-anne
reviewed
Jan 14, 2025
cedric-anne
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
The itemtype selection field for Item questions (Glpi Objects and Dropdowns) has been moved to the question type selection field, so that only the object selection field is in the default value area.
This arrangement is all the more logical as it is not possible to define an item type question without defining an itemtype; it will not be displayed in the final form. This new interface approach forces the user to select an itemtype by default.
PR #18354 introduces some interface modifications to the question type selection fields, notably by grouping them together. It will be important to do the same with this new field once the PR has been merged.
Screenshots (if appropriate):
Before :
Now :