-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k_BT to HPMC integrator #1869
base: trunk-major
Are you sure you want to change the base?
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…hoomd-blue into new_kbT_variant_hpmc Pre-commit to fix code format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have made several suggestions to improve code style. I also found a bug in BoxMC
(not your fault, the variable is named incorrectly).
As an added TODO item, we need to modify hpmc/compute.py
.
- Add
SDF.P
which returnsSDF.betaP * {the current kT}
.
I also considered renaming betaP
to P
, but I now think we should keep betaP
for backwards compatibility. betaP
is also more natural for purely hard particle systems.
…T. (2) Call Operator() on Variant directly. (3) Moved kT out of loop in places. (4) Fixed bug in UpdaterBoxMC.
Description
Previously,$kT$ was assumed to be 1. In this PR, $kT$ is implemented as a variant in the HPMC integrator.
Motivation and context
Assuming$kT = 1$ meant that the well depth of the potential had to be rescaled to simulate different temperatures in the case of patchy particles. It also made interpreting the $\beta P$ output of the SDF compute difficult. With this change,
the temperature can be user-defined.
How has this been tested?
hoomd-validation:
LJ Fluid
LJ Union
Patchy Particle Pressure
MuVT simulation with octahedron particles initialized at$kT=1.0$ and $f=10$
Patchy particle simulation replicating results of the tutorial: 'Modelling Patchy Particles' with varying kT instead of the energy scale
TODO documentation
Change log
Checklist:
sphinx-doc/credits.rst
) in the pull request source branch.