-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh area conservation #1795
Mesh area conservation #1795
Conversation
…th energy and forces by iterating triangles in mesh
mesh_area_conservation should be updated as its parent branch mesh-data-structure has updated
…b/hoomd-blue into mesh_area_conservation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…b/hoomd-blue into mesh_area_conservation
pre-commit.ci autofix |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Now that volume conservation is merged, you need to merge trunk-minor
into this branch and resolve conflicts.
The code looks great. I found a few duplicate or unused lines of code that can be removed.
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…b/hoomd-blue into mesh_area_conservation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This adds two area constraint potentials which can be applied to the mesh data structure.
Motivation and context
These area constraints allow applying a global target area per mesh type or a local target area per mesh triangle to membranes represented by a particle mesh.
How has this been tested?
I added pytests and used this potential in my current studies.
Change log
Checklist:
sphinx-doc/credits.rst
) in the pull request source branch.