Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten requirements generation and testing #819

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

kurtmckee
Copy link
Member

@kurtmckee kurtmckee commented Aug 18, 2023

This PR introduces these changes:

  • test-mindeps requirements are only generated for Python 3.7
  • docs and typing requirements are only generated for Python 3.11
  • CI explicitly uses Python 3.11, not any Python 3 version
  • typing-mindeps no longer exists and will not be tested
  • The Sphinx version restriction is lifted because furo theme was patched in the last 20 hours

This should close most (if not all) Dependabot PRs that were opened against the testing requirements files.


📚 Documentation preview 📚: https://globus-sdk-python--819.org.readthedocs.build/en/819/

@kurtmckee kurtmckee added the no-news-is-good-news This change does not require a news file label Aug 18, 2023
@kurtmckee kurtmckee self-assigned this Aug 18, 2023
Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked our other "3.x" builds to see if anything else looks like it will be impacted, and I think we'll be fine. We can always tweak CI things as needed, but this seems like the right spec in terms of our requirements x versions x builds. So if there's any change needed, it will be minor.

Also, for the public record: we're pretty sure that typing-mindeps isn't an effective test. I'm under the impression that type checkers may bundle/vendor typing-extensions rather than using the installed version.

@kurtmckee kurtmckee merged commit 7473646 into main Aug 18, 2023
27 checks passed
@kurtmckee kurtmckee deleted the only-py37-mindeps branch August 18, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-news-is-good-news This change does not require a news file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants