Use Trusted Publishing #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtmckee
added
the
no-news-is-good-news
kurtmckee
requested review from
aaschaer,
ada-globus,
derek-globus and
sirosen
as code owners
sirosen
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
I've just been reading the GitHub intro to environments; it seems like we have review options and other settings available here.
Are there any details which were necessary when you set these up, or are they basically empty "labels" for now?
They're empty labels. No configuration was required to make it work, but I did find that any attempt to restrict what branch the TestPyPI environment ran against failed miserably...perhaps because it triggers on new tags, not branch pushes? So currently the environments simply exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the SDK GitHub workflows from PyPI token secrets to Trusted Publishing.
The projects on TestPyPI and PyPI have already been updated, and the GitHub environments have already been created.
In addition, this has been tested by creating a
3.27.1b1tag on this branch and pushing it to GitHub to trigger the TestPyPI workflow.📚 Documentation preview 📚: https://globus-sdk-python--805.org.readthedocs.build/en/805/