Add IterableRunLogsResponse
#797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ada <[email protected]>
ada-globus
requested review from
derek-globus,
kurtmckee,
sirosen and
aaschaer
as code owners
kurtmckee
approved these changes
Aug 8, 2023
sirosen
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Yep, this makes sense.
I can't remember how exactly we ended up with default_iter_key and items_key, but I think these developed semi-independently.
I would be happy to work at some point on unifying these a little bit, but for now applying both does the trick.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in the course of working on the
globus flows run get-logscommand that the existing iterator doesn't point to the "entries" key,causing issues when usingPaginator.wrap()which relies on the value of thedefault_iter_key.Update: Subsequently discovered the issue I was encountering arose due to a different issue. I still believe this is correct, but I am reverting to draft while I sort it out.
Update 2: Okay, I can see this is being overridden by the
paging.has_paginatorsetting. I think this is still a very modest improvement to correctness but don't expect a meaningful functional change either. Promoting back to PR.📚 Documentation preview 📚: https://globus-sdk-python--797.org.readthedocs.build/en/797/