Add ComputeClient methods to submit & get tasks #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmello
requested review from
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
m1yag1,
MaxTueckeGlobus and
sirosen
as code owners
rjmello
requested review from
ryanchard,
chris-janidlo,
khk-globus and
LeiGlobus
sirosen
reviewed
Oct 25, 2024
rjmello
force-pushed
the
compute-client-task-methods
branch
from
94b6d2e
to
e7fc5ce
Compare
sirosen
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
This looks good to me, but I want to confirm with the team that get_task_batch looks good to us. Since we don't yet have consistency about always passing a payload object vs passing unpacked fields, I just want to confirm that we're comfortable adding more APIs of both styles (I am, as I think consistency of this sort is only valuable if we can get it library-wide, which will require a major effort with some clear direction).
rjmello
force-pushed
the
compute-client-task-methods
branch
from
e7fc5ce
to
e8487d9
Compare
kurtmckee
approved these changes
Nov 7, 2024
rjmello
force-pushed
the
compute-client-task-methods
branch
from
7a3208e
to
2065429
Compare
- Added the `.get_task()`, `.get_task_batch()`, `.get_task_group()`, and `.submit()` methods to the `ComputeClientV2` class. - Added the `.submit()` method to the `ComputeClientV3` class.
rjmello
force-pushed
the
compute-client-task-methods
branch
from
2065429
to
11edfb8
Compare
kurtmckee
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.get_task(),.get_task_batch(),.get_task_group(), and.submit()methods to theComputeClientV2class..submit()method to theComputeClientV3class.📚 Documentation preview 📚: https://globus-sdk-python--1094.org.readthedocs.build/en/1094/