Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

Row options patch #319

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zry656565
Copy link

@zry656565 zry656565 commented Sep 6, 2016

  • Allow users to select the number of rows in a page
  • You can see the demo in ./test.html

image

  • Three test cases fails because I hide pagination when there is only one page. Should I do that?
Running "karma:unit" (karma) task
................................................................................
....
PhantomJS 1.9.8 (Mac OS X 0.0.0) Reactable pagination specifying more itemsPerPage than items provides buttons for 1 page FAILED
    AssertionError: expected 0 to equal 1
        at /Users/Jerry/Dev/reactable/bower_components/chai/chai.js:925
        at assertEqual (/Users/Jerry/Dev/reactable/bower_components/chai/chai.js:1402)
        at /Users/Jerry/Dev/reactable/bower_components/chai/chai.js:3638
        at /Users/Jerry/Dev/reactable/build/tests/reactable_test.js:3
..............................................
PhantomJS 1.9.8 (Mac OS X 0.0.0) Reactable filtering filtering and pagination together updates the pagination links FAILED
    AssertionError: expected 0 to equal 1
        at /Users/Jerry/Dev/reactable/bower_components/chai/chai.js:925
        at assertEqual (/Users/Jerry/Dev/reactable/bower_components/chai/chai.js:1402)
        at /Users/Jerry/Dev/reactable/bower_components/chai/chai.js:3638
        at /Users/Jerry/Dev/reactable/build/tests/reactable_test.js:24
PhantomJS 1.9.8 (Mac OS X 0.0.0) Reactable filtering filtering and pagination together updates the current page if necessary FAILED
    AssertionError: expected 0 to equal 1
        at /Users/Jerry/Dev/reactable/bower_components/chai/chai.js:925
        at assertEqual (/Users/Jerry/Dev/reactable/bower_components/chai/chai.js:1402)
        at /Users/Jerry/Dev/reactable/bower_components/chai/chai.js:3638
        at /Users/Jerry/Dev/reactable/build/tests/reactable_test.js:26
...................
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 152 of 152 (3 FAILED) (0.464 secs / 0.166 secs)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant