Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline append VM implementation and remove enums #1643

Closed
wants to merge 3 commits into from
Closed

Streamline append VM implementation and remove enums #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9ff226
Streamline append VM implementation
wycats Oct 30, 2024
764160e
Remove some enums
wycats Oct 30, 2024
9f84b28
Remove enums
wycats Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/@glimmer-workspace/integration-tests/lib/setup-harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,18 @@ export async function setupQunit() {
tooltip: 'CI mode makes tests run faster by sacrificing UI responsiveness',
});

QUnit.config.urlConfig.push({
id: 'enable_local_should_log',
label: 'Trace Logging',
tooltip: 'Enable LOCAL_SHOULD_LOG (extra debug logging info)',
});

QUnit.config.urlConfig.push({
id: 'disable_local_debug',
label: 'Disable Debug Assertions',
tooltip: 'Disable LOCAL_DEBUG (debug assertions)',
});

await Promise.resolve();

const qunitDiv = document.createElement('div');
Expand Down
3 changes: 2 additions & 1 deletion packages/@glimmer/compiler/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ export {
s,
unicode,
} from './lib/builder/builder';
export { Builder, type BuilderStatement } from './lib/builder/builder-interface';
export { type BuilderStatement } from './lib/builder/builder-interface';
export * from './lib/builder/constants';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we export explicitly, instead of export *?
From a "knowing what is here" perspective, * feels like an unneeded indirection, and risks leaking things we don't actually want to expose as public API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a lot in here: https://github.com/glimmerjs/glimmer-vm/pull/1643/files#diff-f881a95cdbb07c9ee63e2f6fca320f7d00323b27434dbee753f4cffb38d30a85R6

does it all need to be public API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was all public API but sucked into the Builder enum. And the codebase already does a lot of export *.

export { defaultId, precompile, precompileJSON, type PrecompileOptions } from './lib/compiler';

// exported only for tests!
Expand Down
Loading
Loading