Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup/Build tweaks #1601

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Rollup/Build tweaks #1601

wants to merge 4 commits into from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Aug 20, 2024

More than just terser changes like in #1602


There are a number of flags that are meant to be internal to glimmer-vm and not exposed to ember.js.

There are also flags that are meant to be exposed to ember.js (which are swapped out with DEBUG from '@glimmer/env' during the build)

Output size (using dust)

DevProd
This PR
cd packages/\@glimmer
du --ignore_hidden \
   --reverse --apparent-size \
   --filter ".+\/dist\/dev\/index.js$" \
   --no-percent-bars --only-dir --depth 1

633K └─┬ .
168K   ├── syntax
162K   ├── runtime
104K   ├── compiler
 63K   ├── opcode-compiler
 30K   ├── debug
 23K   ├── manager
 19K   ├── validator
 17K   ├── util
 13K   ├── program
8.9K   ├── reference
6.0K   ├── destroyable
4.5K   ├── vm
4.1K   ├── node
3.7K   ├── global-context
2.5K   ├── wire-format
966B   ├── encoder
844B   ├── vm-babel-plugins
502B   └── owner
cd packages/\@glimmer
du --ignore_hidden \
   --reverse --apparent-size \
   --filter ".+\/dist\/prod\/index.js$" \
   --no-percent-bars --only-dir --depth 1

294K └─┬ .
 74K   ├── syntax
 73K   ├── runtime
 50K   ├── compiler
 25K   ├── opcode-compiler
 21K   ├── debug
 11K   ├── manager
8.7K   ├── util
7.6K   ├── validator
5.9K   ├── program
4.1K   ├── reference
3.0K   ├── destroyable
2.8K   ├── vm
2.1K   ├── node
1.6K   ├── wire-format
1.4K   ├── global-context
604B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner
main
cd packages/\@glimmer
du --ignore_hidden \
   --reverse --apparent-size \
   --filter ".+\/dist\/dev\/index.js$" \
   --no-percent-bars --only-dir --depth 1
   
650K └─┬ .
181K   ├── runtime
162K   ├── syntax
104K   ├── compiler
 63K   ├── opcode-compiler
 29K   ├── debug
 23K   ├── manager
 19K   ├── validator
 17K   ├── util
 13K   ├── program
9.5K   ├── reference
6.2K   ├── destroyable
5.5K   ├── global-context
5.0K   ├── vm
4.2K   ├── node
2.4K   ├── wire-format
967B   ├── encoder
870B   ├── vm-babel-plugins
497B   └── owner
cd packages/\@glimmer
du --ignore_hidden \
   --reverse --apparent-size \
   --filter ".+\/dist\/prod\/index.js$" \
   --no-percent-bars --only-dir --depth 1

301K └─┬ .
 80K   ├── runtime
 74K   ├── syntax
 50K   ├── compiler
 25K   ├── opcode-compiler
 21K   ├── debug
 11K   ├── manager
8.7K   ├── util
7.6K   ├── validator
5.9K   ├── program
4.1K   ├── reference
3.0K   ├── destroyable
2.8K   ├── vm
2.1K   ├── node
1.6K   ├── wire-format
1.4K   ├── global-context
604B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner

Copy link

duration phase no difference [-197ms to 62ms]
renderEnd phase no difference [-2ms to 1ms]
render1000Items1End phase estimated improvement -15ms [-27ms to -3ms] OR -1.18% [-2.15% to -0.22%]
clearItems1End phase no difference [-2ms to 6ms]
render1000Items2End phase no difference [-13ms to 10ms]
clearItems2End phase estimated regression +4ms [0ms to 8ms] OR +5.58% [0.06% to 11.38%]
render5000Items1End phase no difference [-82ms to 0ms]
clearManyItems1End phase no difference [-3ms to 2ms]
render5000Items2End phase no difference [-30ms to 49ms]
clearManyItems2End phase no difference [-5ms to 1ms]
render1000Items3End phase no difference [-12ms to 17ms]
append1000Items1End phase no difference [-9ms to 26ms]
append1000Items2End phase no difference [-37ms to 1ms]
updateEvery10thItem1End phase no difference [-12ms to 5ms]
updateEvery10thItem2End phase no difference [-2ms to 3ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [-2ms to 0ms]
removeFirstRow1End phase no difference [-1ms to 1ms]
removeSecondRow1End phase no difference [-3ms to 0ms]
swapRows1End phase no difference [0ms to 1ms]
swapRows2End phase no difference [-1ms to 0ms]
clearItems4End phase no difference [-7ms to 0ms]
paint phase no difference [0ms to 0ms]

[20:55:50] Generating Benchmark Reports [started]
[20:55:55] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html

@NullVoxPopuli NullVoxPopuli mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant