Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All (ish) performance explorations merged together #1600

Closed
wants to merge 8 commits into from
Closed

All (ish) performance explorations merged together #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5425734
Remove two function calls
NullVoxPopuli Aug 15, 2024
e3986f9
Remove some checks
NullVoxPopuli Aug 16, 2024
7b80c48
Remove move checks
NullVoxPopuli Aug 16, 2024
ea11e3a
Remove the rest of the checks
NullVoxPopuli Aug 19, 2024
0eca410
Use Prod Assets only
NullVoxPopuli Aug 20, 2024
a3996f4
Update benchmark
NullVoxPopuli Aug 20, 2024
d67de32
Merge branch 'explore-performance-3' into compound-test
NullVoxPopuli Aug 20, 2024
c51bada
Merge branch 'explore-performance-2' into compound-test
NullVoxPopuli Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/benchmarks/krausest/vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const currentPath = path.dirname(fileURLToPath(self));
const packagesPath = path.resolve(currentPath, '..', '..', './../packages');

const packagePath = (name: string) => {
return path.join(packagesPath, name, 'dist/prod/index.js');
return path.join(packagesPath, name, 'dist/dev/index.js');
};

export default defineConfig({
Expand Down
6 changes: 3 additions & 3 deletions packages/@glimmer-workspace/build/lib/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,12 @@ export class Package {
let builds = [];

if (formats.esm ?? true) {
builds.push(...this.rollupESM({ env: 'dev' }));
// builds.push(...this.rollupESM({ env: 'dev' }));
builds.push(...this.rollupESM({ env: 'prod' }));
}

if (formats.cjs ?? true) {
builds.push(...this.rollupCJS({ env: 'dev' }));
builds.push(...this.rollupCJS({ env: 'prod' }));
}

return builds;
Expand Down Expand Up @@ -418,7 +418,7 @@ export class Package {
return {
input: resolve(root, ts),
output: {
file: resolve(root, 'dist', env, file),
file: resolve(root, 'dist', 'dev', file),
format,
sourcemap: true,
exports: format === 'cjs' ? 'named' : 'auto',
Expand Down
3 changes: 0 additions & 3 deletions packages/@glimmer/manager/lib/util/capabilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import type {
WithUpdateHook,
WrappedCapability,
} from '@glimmer/interfaces';
import { check, CheckNumber } from '@glimmer/debug';
import { InternalComponentCapabilities } from '@glimmer/vm';

export const FROM_CAPABILITIES = import.meta.env.DEV ? new WeakSet() : undefined;
Expand Down Expand Up @@ -104,14 +103,12 @@ export function managerHasCapability<F extends InternalComponentCapability>(
capabilities: CapabilityMask,
capability: F
): _manager is InternalComponentCapabilityFor<F> {
check(capabilities, CheckNumber);
return !!(capabilities & capability);
}

export function hasCapability(
capabilities: CapabilityMask,
capability: InternalComponentCapability
): boolean {
check(capabilities, CheckNumber);
return !!(capabilities & capability);
}
Loading
Loading