[BUGFIX] Add output tag to attributes override

(cherry picked from commit 38a991b)
glimmerjs · Nov 20, 2020 · 8295f7f · 8295f7f
1 parent 4f2505c
commit 8295f7f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/@glimmer/integration-tests/test/attributes-test.ts b/packages/@glimmer/integration-tests/test/attributes-test.ts
@@ -180,6 +180,19 @@ export class AttributesTests extends RenderTest {
     this.assertStableRerender();
   }
 
+  @test
+  'can set attributes on form properties'() {
+    this.render('<form id={{foo}}></form><output form={{foo}}></output>', { foo: 'bar' });
+
+    let outputElement = assertElement(this.element.lastChild);
+
+    this.assert.ok(hasAttribute(outputElement, 'form'));
+    this.assert.equal(this.readDOMAttr('form', outputElement), 'bar');
+
+    this.assertStableRerender();
+    this.assertStableNodes();
+  }
+
   @test
   'handles null input values'() {
     this.render('<input value={{isNull}} />', { isNull: null });

diff --git a/packages/@glimmer/runtime/lib/dom/props.ts b/packages/@glimmer/runtime/lib/dom/props.ts
@@ -66,6 +66,7 @@ const ATTR_OVERRIDES: Dict<Dict> = {
   FIELDSET: { form: true },
   LEGEND: { form: true },
   OBJECT: { form: true },
+  OUTPUT: { form: true },
   BUTTON: { form: true },
 };