Skip to content

Commit

Permalink
delegate call to delegate
Browse files Browse the repository at this point in the history
  • Loading branch information
patricklx authored Jun 26, 2024
1 parent aeeb243 commit 087ed50
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions packages/@glimmer/manager/lib/public/modifier.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,11 @@ export class CustomModifierManager<O extends Owner, ModifierInstance>
return state;
}

getDebugName(definition: object) {
getDebugName(owner: O, definition: object) {

Check failure on line 120 in packages/@glimmer/manager/lib/public/modifier.ts

View workflow job for this annotation

GitHub Actions / Linting

Property 'getDebugName' in type 'CustomModifierManager<O, ModifierInstance>' is not assignable to the same property in base type 'InternalModifierManager<CustomModifierState<ModifierInstance>, object>'.
let delegate = this.getDelegateFor(owner);
if (typeof delegate.getDebugName === 'function') {

Check failure on line 122 in packages/@glimmer/manager/lib/public/modifier.ts

View workflow job for this annotation

GitHub Actions / Linting

Property 'getDebugName' does not exist on type 'ModifierManager<ModifierInstance>'.
return delegate.getDebugName(definition);

Check failure on line 123 in packages/@glimmer/manager/lib/public/modifier.ts

View workflow job for this annotation

GitHub Actions / Linting

Property 'getDebugName' does not exist on type 'ModifierManager<ModifierInstance>'.
}
if (typeof definition === 'function') {
if (definition.toString !== Function.toString) {
return definition.toString();
Expand All @@ -128,8 +132,12 @@ export class CustomModifierManager<O extends Owner, ModifierInstance>
}
}

getDebugInstance({ modifier }: CustomModifierState<ModifierInstance>) {
return modifier;
getDebugInstance(owner: O, state: CustomModifierState<ModifierInstance>) {

Check failure on line 135 in packages/@glimmer/manager/lib/public/modifier.ts

View workflow job for this annotation

GitHub Actions / Linting

Property 'getDebugInstance' in type 'CustomModifierManager<O, ModifierInstance>' is not assignable to the same property in base type 'InternalModifierManager<CustomModifierState<ModifierInstance>, object>'.
let delegate = this.getDelegateFor(owner);
if (typeof delegate.getDebugInstance === 'function') {

Check failure on line 137 in packages/@glimmer/manager/lib/public/modifier.ts

View workflow job for this annotation

GitHub Actions / Linting

Property 'getDebugInstance' does not exist on type 'ModifierManager<ModifierInstance>'.
return delegate.getDebugInstance(state);

Check failure on line 138 in packages/@glimmer/manager/lib/public/modifier.ts

View workflow job for this annotation

GitHub Actions / Linting

Property 'getDebugInstance' does not exist on type 'ModifierManager<ModifierInstance>'.
}
return state.modifier;
}

getTag({ tag }: CustomModifierState<ModifierInstance>) {
Expand Down

0 comments on commit 087ed50

Please sign in to comment.