Allow spaces in locale key #604
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
reviewed
Oct 28, 2024
| @@ -20,7 +20,7 @@ def strip_literal(literal) | |||
| literal | |||
| end | |||
|
|
|||
| VALID_KEY_CHARS = %r{(?:[[:word:]]|[-.?!:;À-ž/])}.freeze | |||
| VALID_KEY_CHARS = %r{(?:[[:word:]]|[-.?!:;À-ž/]|(?<=\w)\s(?=\w))}.freeze | |||
There was a problem hiding this comment.
Should this perhaps match all Unicode letters in the context rather than just a-z?
https://rubular.com/r/dOnUgvJhli6Il2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows spaces in translation keys.
Previously, keys containing spaces (e.g., "Key with Spaces") were not considered valid and were removed from the results after scanning the file. With this change, translation keys with spaces are now recognized as valid.
Closes #359