Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses AST-scanner for all ERB #573

Merged
merged 2 commits into from
May 14, 2024
Merged

Uses AST-scanner for all ERB #573

merged 2 commits into from
May 14, 2024

Conversation

davidwessman
Copy link
Collaborator

@davidwessman
Uses AST-scanner for all ERB
aec6c28 
- Also fixes regex in PatternScanner to handle `theme_t "foo"` being
  marked as a translation.
- Fixes #572
@davidwessman
Copy link
Collaborator Author

@mvz Can you test it out? 🙂

@davidwessman davidwessman requested a review from glebm May 13, 2024 21:12
glebm
glebm reviewed May 14, 2024
View reviewed changes
CHANGES.md Outdated
## v1.0.14

* Newlines are now preserved when using Google Translate.
- Newlines are now preserved when using Google Translate.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert the changes from - to *?

@glebm
Copy link
Owner

glebm commented May 14, 2024

Looks good to me other than the markdown formatting change

@davidwessman davidwessman requested a review from glebm May 14, 2024 05:18
@davidwessman
Copy link
Collaborator Author

Looks good to me other than the markdown formatting change

Need to find some better settings for the VS Code repo to avoid automatic formatting.

@davidwessman davidwessman merged commit 80f9ab0 into main May 14, 2024
8 checks passed
@davidwessman davidwessman deleted the handles-all-erb branch May 14, 2024 06:11
@mvz
Copy link
Contributor

mvz commented May 14, 2024

@davidwessman I have tested with these changes and it works now. Thanks!

@gregorbg
Copy link

gregorbg commented Jun 3, 2024

I'm a little worried that this may cause regressions for #537.

The limitation to only .html.erb was deliberately introduced here: #543
This current PR looks like it exactly reverts the fix from that other PR. What will happen to .js.erb files again when this change is released?

@davidwessman
Copy link
Collaborator Author

I'm a little worried that this may cause regressions for #537.

The limitation to only .html.erb was deliberately introduced here: #543

This current PR looks like it exactly reverts the fix from that other PR. What will happen to .js.erb files again when this change is released?

There is a new scanner that handles it 🙂 and there are tests for it.

@davidwessman
Copy link
Collaborator Author

But please add some tests if you think there needs to be more test coverage for it.

@davidwessman
Copy link
Collaborator Author

#545

Here is the new parser 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glebm glebm Awaiting requested review from glebm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 1.0.14 thinks any method ending in _t is a translation method
4 participants
@davidwessman @glebm @mvz @gregorbg