Provide more informative error for dynamic.dict when value fails #746
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Nov 20, 2024
sporto
force-pushed
the
dynamic-dict-2
branch
from
0f7aa26 to
ed7ebb9
Compare
sporto
force-pushed
the
dynamic-dict-2
branch
from
ed7ebb9 to
ac33905
Compare
|
@lpil PR updated |
sporto
changed the title
|
It's still not using the wrong format I'm afraid. Check out push_path and how that works with field. You may also want to look at the new decoder API now too |
|
Hello, I'm afraid I don't follow. This is using the code from push_path. Could you please clarify what format you expect to see? Otherwise, I think I'm just guessing. |
|
Don't add a new syntax to push_path in any way, just use the string! You can use field and push_path as a reference. See how neither uses C style angle brackets in the path. Note this code is now going to be deprecated very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#740
Something like this perhaps?
@lpil you mentioned that the module already defines logic for turning any value into a string for use in the error path.
Which function is that?
Thanks