Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Write basics of email service #1099

Closed
wants to merge 5 commits into from

Conversation

mohammadranjbarz
Copy link
Collaborator

related to #1047

@kristoferlund I couldnt test it because we need to verify our domain https://docs.sendgrid.com/for-developers/sending-email/sender-identity

And also I think it's better to manage templates ourselves with creating some HTMLs it can be easier to get to know their services and temlates

@mohammadranjbarz mohammadranjbarz changed the title Write basics of email service WIP Write basics of email service Jun 29, 2023
@kristoferlund
Copy link
Member

@kristoferlund I couldnt test it because we need to verify our domain https://docs.sendgrid.com/for-developers/sending-email/sender-identity

@mohammadranjbarz I believe we already have verified domain.

Screenshot 2023-06-30 at 13 57 40

And also I think it's better to manage templates ourselves with creating some HTMLs it can be easier to get to know their services and temlates

Could you tell me more? What are the benefits of managing the templates in the code? Or perhaps, what are the drawbacks of using SendGrid templates? The big benefit is that we can give Justina or Ahmad or a designer the access to sendgrid and allow them to modify templates without us having to rebuild the code.

Final comment. We should follow the Nest.js design patterns and build the email sender service as a real service. Now you have constructed it as a utility function.

@mohammadranjbarz
Copy link
Collaborator Author

@kristoferlund I couldnt test it because we need to verify our domain https://docs.sendgrid.com/for-developers/sending-email/sender-identity

@mohammadranjbarz I believe we already have verified domain.

Screenshot 2023-06-30 at 13 57 40 > And also I think it's better to manage templates ourselves with creating some HTMLs it can be easier to get to know their services and temlates

Could you tell me more? What are the benefits of managing the templates in the code? Or perhaps, what are the drawbacks of using SendGrid templates? The big benefit is that we can give Justina or Ahmad or a designer the access to sendgrid and allow them to modify templates without us having to rebuild the code.

Final comment. We should follow the Nest.js design patterns and build the email sender service as a real service. Now you have constructed it as a utility function.

Yeah I agree with you, thanks for your feedbacks, I'll work on them

@mohammadranjbarz
Copy link
Collaborator Author

@kristoferlund I made the changes that you needed, but still I couldn't test it, will message you on DM about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants