Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(branches): Users in branch protections always deleted and added #594

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

stevoland
Copy link
Contributor

type property ("User") is matched as the identifier before login so the diff always adds addition/deletion.

Theoretically this fix could break some other diff use-case and I wouldn't know

Copy link
Collaborator

@decyjphr decyjphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@decyjphr decyjphr merged commit 657a1c0 into github:main-enterprise Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants